Use some utf8 string literals #6591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @SimonCropp, sorry for letting this lie. In general it would be great to first outline the work that you want to do in an issue. Since you touched the parser this needs to go to our benchmark machines. I will issue tests next week. I know that the change you have done should not in general change perf characteristics but we do it nevertheless always when these parts are touched. Results will be posted by the bot later here. Also you need to sign the CLA for this to move along. Have a look at the message from the CLA bot... should take no more than 2 minutes. |
|
Also, thank you for contributing :) |
|
@michaelstaib Any updates on the benchmarks? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.